Fix #2740, write i18n.csv on demand #2741
Conversation
ghost
requested review from
| @@ -322,6 +320,7 @@ private void LoadMenu() | |||
| CreateMenuItem("Show Logs...", new EventHandler(this.ShowLogItem_Click)), | |||
| this.VerboseLoggingToggleItem = CreateMenuItem( "Verbose Logging", new EventHandler(this.VerboseLoggingToggleItem_Click) ), | |||
| this.ShowPluginOutputToggleItem = CreateMenuItem("Show Plugin Output", new EventHandler(this.ShowPluginOutputToggleItem_Click)), | |||
| this.WriteI18NFileItem = CreateMenuItem("Write translation template",new EventHandler(WriteI18NFileItem_Click)), | |||
There was a problem hiding this comment.
Why need this menu? What will happen if user generated an old csv file then user upgrade SS to a new version with new UI elements?
There was a problem hiding this comment.
Why need this menu?
user can translate the program by edit generated csv
What will happen
New translation won't apply
There was a problem hiding this comment.
New translation won't apply
IMO, if users need a new language or amend the translation, let them send pull request. Otherwise, by use of an external translation file may cause some "out-of-date" problem after upgrade.
There was a problem hiding this comment.
If you feel it doesn't matter, please merge the PR.
There was a problem hiding this comment.
My programming is bad...
Looks good, build succeeded, I think is good.
There was a problem hiding this comment.
"out-of-date" problem
will implement translate file merge to resolve this
There was a problem hiding this comment.
will implement translate file merge to resolve this
What will happen if there is a conflict or obsoleted item in new version? This is what I am worrying about. Too much user interactions.
Or your design purpose is to switch between "integrated translation resource" and "external translation file" in the future?
There was a problem hiding this comment.
conflict
use external one, as user may changed it
obsoleted
just keep it, user can downgrade version
There was a problem hiding this comment.
OK I will draft a new release soon
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.