deprecate unsafe encryption method #2757
Conversation
ghost
added this to the 
ghost
requested review from
|
+1 |
|
I may rewrite the entire config form in data binding pattern in the coming weeks. （咕咕咕） |
Let's discuss it in v5 update plan? |
sure |
|
@studentmain you could merge this pull request if you are confident. |
shadowsocks-csharp/Data/i18n.csv
Outdated
| @@ -74,6 +74,7 @@ Apply,应用,應用,適用 | |||
| New server,未配置的服务器,新伺服器,新規サーバー | |||
| Move &Up,上移(&U),上移 (&U),上に移動 (&U) | |||
| Move D&own,下移(&O),下移 (&O),下に移動 (&O) | |||
| deprecated,不推荐,, | |||
There was a problem hiding this comment.
The translation should be done?
|
Rebased the code and add new translations. |
|
Redirect attack on Shadowsocks stream ciphers https://github.com/edwardz246003/shadowsocks |
Let's depercate them in v5 then. |
|
Or more aggressive, deprecate them now, and delete them in v5? |
Agree |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
Close #2715, some heavy modify in ConfigForm.cs in order to show deprecated warning in EncryptionSelect