deprecate all stream cipher #2801
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Now the insecure ciphers are removed from UI combobox but user could still use them from existing configuration these days as grace period. Should we popup info message when launching SS (or opening config form) when config file contains any of insecure (unsupported) ciphers? |
Prefer do it when user updated to new version, that need #2778 |
celeron533
approved these changes
Feb 18, 2020
|
在重新考虑丢弃一些流加密的时间，aes-cfb，chacha20-ietf，rc4-md5仍然有比较广泛的用户基础（加起来和AEAD用户差不多数量）。而且鉴于我把它们重新实现了，所以在v5版中考虑保留这三个和plain加密，但需要在配置文件中手动启用并且不提供技术支持。 |
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shadowsocks/shadowsocks-org#154
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
Mark all stream cipher deprecated. Planning to remove them in V5.
shadowsocks/shadowsocks-org#154