New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shader_recompiler: Shader param fixups #1199

Merged

georgemoralis merged 1 commit into shadps4-emu:main from squidbus:params-fixup

Oct 3, 2024

Contributor

squidbus commented Oct 2, 2024

Use GetAttributeInfo to construct attribute infos more to simplify correct construction.
Allow passing num_components to GetAttributeInfo. Currently still always 4 but more correct this way.
Add asserts to make sure input parameters array is not overrun.
Fix missing boolean parameter and incorrect pointer type in one of the input attribute declarations.
Use existing constants for params and fragment outputs array sizes.
Misc style cleanup.


          shader_recompiler: Shader param fixups

2ec4a79

squidbus force-pushed the params-fixup branch from 21ef9cf to 2ec4a79 Compare

October 2, 2024 11:32

Contributor Author

squidbus commented Oct 2, 2024

Fixes regression in CUSA05133

georgemoralis merged commit 7209b7d into shadps4-emu:main

10 checks passed

squidbus deleted the params-fixup branch

October 15, 2024 06:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet