renderer_vulkan: Implement rectlist emulation with tessellation #1857
Conversation
raphaelthegreat
force-pushed
the
rectlist-tess
branch
from
4132edd to
a7c58d6
Compare
raphaelthegreat
force-pushed
the
rectlist-tess
branch
from
a7c58d6 to
0925d58
Compare
|
Is this case related to spiky polygon syndrome in BloodBorne ? (face vertices are blown away sometimes) |
|
This shouldn't solve vertex explosions no |
|
Build 059678с With this PR, I was able to launch [CUSA00005] RESOGUN. (This doesn't happen in "Main" for me.) Also, this does not apply to this PR, but when running Gravity Rush 2 on this build, an error appears:
|
|
This PR improves the graphics in Main Build: (More Screenshots)Main Build: PR: Log: |
| @@ -238,7 +238,7 @@ void Rasterizer::Draw(bool is_indexed, u32 index_offset) { | |||
| instance_offset); | |||
| } else { | |||
| const u32 num_vertices = | |||
| regs.primitive_type == AmdGpu::PrimitiveType::RectList ? 4 : regs.num_indices; | |||
| regs.primitive_type == AmdGpu::PrimitiveType::RectList ? 3 : regs.num_indices; | |||
There was a problem hiding this comment.
Is this supposed to still be changing the num_vertices? Thought this was supposed to support proper number of vertices e.g. multiple rectangles.
There was a problem hiding this comment.
This is debugging leftover yes, can just use regs.num_indices
| @@ -1,6 +1,6 @@ | |||
| // SPDX-FileCopyrightText: Copyright 2024 shadPS4 Emulator Project | |||
| // SPDX-License-Identifier: GPL-2.0-or-later | |||
|
|
|||
| #pragma clang optimize off | |||
| using Sirit::Id; | ||
|
|
||
| struct QuadRectListEmitter : public Sirit::Module { | ||
| explicit QuadRectListEmitter(size_t num_attribs_) |
There was a problem hiding this comment.
Should pass supported SPIR-V version to Sirit::Module like so:
Otherwise emits a validation error on Vulkan 1.2.
There was a problem hiding this comment.
Can also pass a fixed, lower version (<= 1.5 I think) as I suppose newer isn't needed.
|
Seems to be working on Mac from my testing so far, other than the SPIR-V version validation error I mentioned. |
RectLists are a primitive types that renders a quad, given only 3 vertices, by interpolating the fourth one. There is no similar primitive provided by the vulkan API, so we have to emulate it. On main this is a bit of a hack, where we change it to either TriangleStrip/TriangleFan and adjust the number of drawn vertices.
For this to work however, several assumptions must be true. The shader must auto-generate the vertices (no vertex buffer bound), it must also generate a proper fourth vertex to form a quad and only draw 1 quad. These requirements often are true, but not always. And even if they are, sometimes it still doesn't render properly due to changes in ordering.
In this PR we remove the hacks and implement RectList primitive using auxiliary tessellation shaders. The interpolation method is referenced from GRVK: https://github.com/libcg/grvk/blob/03d43a5a/src/amdilc/amdilc_rect_gs_compiler.c#L141
Most existing implementations use a geometry shader for this, but we opted not to for several reasons. Firstly macos doesn't support geoshaders and thus would not be able to benefit, while tessellation shaders should be supported. Also tessellation shaders will work in all cases of RectList usage without interfering with pipeline. It is possible for guest to configure RectLists together with a guest geometry shaders, which would break if we had to insert our own geometry shader. Using tessellation requires patch primitive type instead, so this problem doesn't exist.
Should fix cases of poking triangles in the screen.