tile: Fix some tile thickness calculation errors. #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more fix: the mip height should not be padded to tile height as this is handled with appropriate mip size value calculation. Height should still just be the actual mip image height. This fixes some of the remaining issues I was seeing with a 3D image where one of the slices would be garbage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some mistakes from updates to tile calculations related to volume thickness:
ImageSizeMicroTiledinUpdateSize.ImageSizeMicroTiledshould not return size multiplied with thickness, only use it for pitch alignment padding condition. Returned value will be multiplied with full texture depth after.