chore: config files ts migration and refactor #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5867147186
💛 - Coveralls |
|
⏳ Generating Lighthouse report... |
likhith-deriv
approved these changes
Aug 18, 2023
matin-deriv
approved these changes
Aug 18, 2023
shahzaib-deriv
approved these changes
Aug 18, 2023
likhith-deriv
merged commit 9be3bdf
into
shahzaib-deriv:KYC-accounts-package-TS-migration--test-coverage/sprint-8
1 check passed
shahzaib-deriv
added a commit
that referenced
this pull request
Oct 5, 2023
* fix: ⚡ refactored Address-details component * fix: 🎨 failing testcases * refactor: ♻️ incorporated review comments * feat: 🔥 removed PlatformContext * fix: testcase failure * refactor: ♻️ incorporated review comments * refactor: ♻️ refactor component to remove unwanted code (binary-com#44) * refactor: ♻️ refactor component to remove unwanted code * feat: removed commented code * test: ✅ added testcase * test: 🧪 added tests * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * refactor: ♻️ migrated code to TS (binary-com#45) * refactor: ♻️ migrated code to TS * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * Update packages/account/src/Types/common-prop.type.ts Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> * refactor: ⚡ refactored currency selector component (binary-com#43) * refactor: ⚡ refactored currency selector component * fix: 🚨 lint errors * feat: incorporated store values * fix: 🎨 split code into small components * fix: 🎨 removed un-necessary array * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated review comments * resolved failing test cases * chore: incorporated review comment * fix: build issue * fix: build issue * ref: incorporated review comments * refactor: Modified code to contain hooks * refactor: Modified code to contain hooks * replaced test component * fix: eslint issues * fix: failing testcases * ref: Incorporated review somments * Likhith/webrel 780/migrate Email and password section (#7) * chore: migrated deriv-email and unlink component * chore: migrate password-platform to tsx * chore: migrate password-platform to tsx * chore: added missing test cases * ref: incorporated review comments * refactor: incorporated review comments * refactor: incorporated review comments * refactor: incorporated review comments * ref: Incorporated review somments * chore: config files ts migration and refactor (#8) * chore: config files ts migartion and refactor * refactor: test case for config func * fix: config typing * refactor: remove custom accounts residence type * refactor: review comment * chore: added test cases * fix: revert boolean in types * refactor: default value fields * refactor: files types, import react types * refactor: react types * fix: condition rule * fix: failing testcase --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: incorporated review comments * fix: failing testcase * refactor: migrate form-fields file (#10) * refactor: migrate form-fields file * refactor: migrate form-fields file * ref: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: incorporated review comments * fix: incorporated review comments * fix: resolved Sonar lint errors * fix: tslint issues * fix: review comments * fix: review comments * refactor: 🎨 incorporated types for test cases * fix: 🦺 incorporated review comments * fix: 🎨 incorporated ui-store-fix * fix: ⚰️ replaced deprecated hooks * fix: 🔥 unused dependency * Merge branch 'master' into KYC-accounts-package-TS-migration--test-coverage/sprint-8 * chore: added package-lock * fix: added value for mock-store --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Shahzaib <shahzaib@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.