Skip to content

Commit

Permalink
build: Disable warnings in third-party code (#1353)
Browse files Browse the repository at this point in the history
We already disabled warnings-as-errors in third-party code, but this
goes futher to completely disable third-party warnings. They are mostly
noise, and distracting. If they aren't errors, we shouldn't have our
build logs flooded with them.
  • Loading branch information
joeyparrish authored Feb 27, 2024
1 parent 6276584 commit 673e49d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packager/third_party/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ else()
# Surprisingly, both of these are required to satisfy various platforms and
# compilers at once.
add_compile_options(-Wno-error -Wno-error=all)
# Hide warnings in third-party code. The noise isn't helpful, and this line
# can be commented out if we ever want to see/audit third-party warnings.
add_compile_options(-w)
endif()

# These all use EXCLUDE_FROM_ALL so that only the referenced targets get built.
Expand Down

0 comments on commit 673e49d

Please sign in to comment.