Skip to content

Commit

Permalink
fix: apply cmake fixes after merge of #1210 (#1264)
Browse files Browse the repository at this point in the history
build in CMake branch is broken at least locally on OS X after #1210 was
merged which introduced some new warnings and reintroduced
base::nullopt.
  • Loading branch information
cosmin authored Sep 19, 2023
1 parent 5557e76 commit 8b87804
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packager/mpd/base/adaptation_set.cc
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ std::optional<xml::XmlNode> AdaptationSet::GetXml() {
!adaptation_set.AddSupplementalProperty(
"urn:mpeg:mpegB:cicp:TransferCharacteristics",
std::to_string(transfer_characteristics_))) {
return base::nullopt;
return std::nullopt;
}

// Note: must be checked before checking segments_aligned_ (below). So that
Expand Down
2 changes: 1 addition & 1 deletion packager/mpd/base/adaptation_set.h
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class AdaptationSet {
void set_codec(const std::string& codec) { codec_ = codec; };

/// @return transfer_characteristics.
const uint32_t transfer_characteristics() const {
uint32_t transfer_characteristics() const {
return transfer_characteristics_;
}

Expand Down
1 change: 1 addition & 0 deletions packager/mpd/base/mpd_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include <libxml/tree.h>

#include <cstdint>
#include <list>
#include <string>

Expand Down

0 comments on commit 8b87804

Please sign in to comment.