Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set yuv full range flag to 1 for VP9 with sRGB #1398

Merged
merged 2 commits into from
May 11, 2024

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented May 9, 2024

If color_space is VPX_COLOR_SPACE_SRGB, the specs says that color_range should be 1 i.e. yuv_full_range = true. However, yuv_full_range is default initialized as false and isn't set in the branch for color_space is VPX_COLOR_SPACE_SRGB.

Fixes #990

@cosmin cosmin requested a review from joeyparrish May 9, 2024 23:44
@@ -285,6 +285,7 @@ bool ReadBitDepthAndColorSpace(BitReader* reader,
}
} else {
// Assume 4:4:4 for colorspace SRGB.
yuv_full_range = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's a bool, so yuv_full_range = true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -285,6 +285,7 @@ bool ReadBitDepthAndColorSpace(BitReader* reader,
}
} else {
// Assume 4:4:4 for colorspace SRGB.
yuv_full_range = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cosmin cosmin merged commit f6f60e5 into shaka-project:main May 11, 2024
35 checks passed
@cosmin cosmin deleted the vp9-srgb-full-range branch May 11, 2024 00:41
cosmin pushed a commit that referenced this pull request May 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.2.0](v3.1.0...v3.2.0)
(2024-05-11)


### Features

* support Dolby Vision profile 8.x (HEVC) and 10.x (AV1) in HLS and DASH
([#1396](#1396))
([a99cfe0](a99cfe0))


### Bug Fixes

* adaptation set IDs were referenced by lowest representation ID
([#1394](#1394))
([94db9c9](94db9c9)),
closes
[#1393](#1393)
* escape media URLs in MPD
([#1395](#1395))
([98b44d0](98b44d0))
* set yuv full range flag to 1 for VP9 with sRGB
([#1398](#1398))
([f6f60e5](f6f60e5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect implementation of color_range in VP9?
2 participants