-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS / DASH support for forced subtitles #988
Comments
That is not supported right now. To support DASH To support HLS @vish91 Do you want to work on it? |
@kqyang i am also interested in this function it would be great if you could implement it |
@kqyang for DASH I understood and made progress. |
Yes, it needs to be a stream descriptor property. The media playlist tag property is derived internally in the code. I think you can define it as a boolean and parse it in the same way as |
@kqyang gotcha and if its a stream descriptor. Does it still need to be declared or set after parsing it in stream_descriptor.cc ? Like how the hls_characterisctics after parsing are still being set in media_playlist.cc and hls_notify_muxer_listener. Trying to gauge where the actual conversion would happen from when it's parsed as bool in stream_descriptor to where the media_playlist is getting created. |
Yes, I suggest defining an accessor in media_playlist.h similar to characteristics() function.
I don't think we should set AUTOSELECT to YES for FORCED subtitles. |
According to rule 5.11 of the HTTP Live Streaming (HLS) authoring specification for Apple devices forced subtitles SHOULD always have |
Closes #988 --------- Co-authored-by: Cosmin Stejerean <cstejerean@meta.com>
Does shaka-packager support setting forces subtitles in HLS and DASH. Mainly DASH ?
In HLS it's the stream media tag
FORCED
and in DASH its a ROLE
forced-subtitles
Dash-Industry-Forum/DASH-IF-IOP#165
Dash-Industry-Forum/Ingest#40
Based on the first issue it looks like Shaka-player and ExoPlayer do support it for HLS and DASH
The text was updated successfully, but these errors were encountered: