Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dash_roles add role=description for DVS audio per DASH-IF-IOP-v4.3 #1054

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

vish91
Copy link
Contributor

@vish91 vish91 commented Apr 18, 2022

Fixes support for description role for audio DVS tracks.
as per spec:
dash-accessibility-roles

@vish91
Copy link
Contributor Author

vish91 commented Apr 19, 2022

@kqyang @joeyparrish if you can take a look please ^
Apart from the PR I have some other issues on the side with the main branch , I can't seem to build it on my machine cleanly everytime. Any changes regarding the build instructions recently ?

@joeyparrish joeyparrish merged commit dc03952 into shaka-project:main Jun 2, 2022
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
….3 (shaka-project#1054)

Fixes support for description role for audio DVS tracks as per spec.
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
….3 (shaka-project#1054)

Fixes support for description role for audio DVS tracks as per spec.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants