feat: port media/test #1116
Merged
feat: port media/test #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite test_data_util.h to locate files relative to the source file itself, rather than using a service from chromium base::. This makes the functionality header-only, but there is no meaningful downside to inlining complex functions for tests.
|
Ah great, thanks Joey |
I was wrong! Now that I'm progressing through tests, I'm getting duplicate symbol errors at linking. This needs to be updated. |
|
This is working now. After this lands, I have another PR ready with the crypto code from media/base, which needed a lot of changes. |
theodab
approved these changes
Oct 25, 2022
zdanek
suggested changes
Oct 25, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite test_data_util.cc to locate files relative to the source file itself, rather than using a service from chromium
base::.Issue #1047 (CMake porting)
Issue #346 (absl porting)