feat: port media/base #1127
Merged
feat: port media/base #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all chromium dependencies from media/base/ and completes the build system in CMake. The ClosureThread class and its classes were removed, as they were specific to chromium base. ClosureThread has been replaced by std::thread. The byte-swapping utilities in network_util.cc have been removed and replaced with absl. generate_unique_temp_path() was split out of file_unittest.cc into file_test_util.cc, where other test suites could make use of it. WARN_UNUSED_RESULT was replaced with the C++ standard attribute [[nodiscard]]. The base::Clock interface was replaced with a typedef for a function pointer that returns the current time. This re-enables the tests in http_key_fetcher_unittest.cc by using httpbin.org.
This does not depend on absl, which frees macros.h from any library deps that would make the CMake dependency tree more complicated. This also fixes build errors in some environments.
theodab
requested changes
Nov 3, 2022
See if this fixes some issues on arm64 and docker, that may be to do with resource constraints
This appears to fix some issues with crashing compilers on arm64 and docker builds. This may be caused by resource constraints in those environments.
theodab
approved these changes
Nov 4, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all chromium dependencies from media/base/ and completes the build system in CMake.
The ClosureThread class and its classes were removed, as they were specific to chromium base. ClosureThread has been replaced by std::thread.
The byte-swapping utilities in network_util.cc have been removed and replaced with absl.
generate_unique_temp_path() was split out of file_unittest.cc into file_test_util.cc, where other test suites could make use of it.
WARN_UNUSED_RESULT was replaced with the C++ standard attribute [[nodiscard]].
The base::Clock interface was replaced with a typedef for a function pointer that returns the current time.
This re-enables the tests in http_key_fetcher_unittest.cc by using httpbin.org.
Issue #1047 (CMake porting)
Issue #346 (absl porting)