fix: Prevent crash in GetEarliestTimestamp() if periods are empty #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murillo128, could you please fix any build and/or linter errors? |
joeyparrish
added
the
status: waiting on response
joeyparrish
changed the title
joeyparrish
changed the title
|
@murillo128, you have trailing whitespace in your change, but you did not give me rights to edit your PR to fix it. Please delete the trailing whitespace. |
joeyparrish
approved these changes
Jul 12, 2023
|
Thanks! |
|
thank you too Joey! |
github-actions
bot
removed
the
status: waiting on response
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I have not yet found why the periods are empty, this will prevent shaka from seg faulting
Fixes #1172