Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port media/formats/* to cmake #1258

Merged
merged 14 commits into from
Aug 31, 2023
Merged

feat: port media/formats/* to cmake #1258

merged 14 commits into from
Aug 31, 2023

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented Aug 22, 2023 •
edited by joeyparrish
Loading

Issue #1047

@cosmin cosmin mentioned this pull request Aug 29, 2023
Merged
joeyparrish
joeyparrish requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally reviewed. Sorry it took so long to make time for this!

packager/media/base/muxer.h Outdated Show resolved Hide resolved
packager/media/formats/wvm/wvm_media_parser.cc Outdated Show resolved Hide resolved
packager/third_party/libpng/CMakeLists.txt Outdated Show resolved Hide resolved
packager/utils/absl_flag_hexbytes.cc Outdated Show resolved Hide resolved
packager/utils/absl_flag_hexbytes.cc Outdated Show resolved Hide resolved
packager/utils/absl_flag_hexbytes.h Outdated Show resolved Hide resolved
@joeyparrish
Copy link
Member

Ship it! 🎉 🚀

@joeyparrish joeyparrish merged commit 3afe761 into shaka-project:cmake Aug 31, 2023
32 checks passed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmin @joeyparrish