Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix clang build #1288

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: Fix clang build #1288

merged 1 commit into from
Oct 18, 2023

Conversation

joeyparrish
Copy link
Member

Issue #561

@cosmin cosmin merged commit bcc2754 into shaka-project:cmake Oct 18, 2023
32 checks passed
@joeyparrish joeyparrish deleted the fix-clang branch October 19, 2023 00:20
@joeyparrish joeyparrish mentioned this pull request Oct 20, 2023
Merged
joeyparrish added a commit to joeyparrish/shaka-packager that referenced this pull request Nov 30, 2023
@joeyparrish
feat!: Rewrite build system and third-party dependencies
e86e5ef 
This work was done over ~80 individual commits in the `cmake` branch.

BEGIN_COMMIT_OVERRIDE
feat!: Replace gyp build system with CMake

Closes shaka-project#1047

feat!: Update all dependencies
fix: Fix Python 3.10+ compatibility in scripts
feat!: Drop Python 2 support in all scripts
feat!: Replace glog with absl::log, tweak log output and flags
feat: Add install target to build system
feat: Respect the file mode for HttpFiles (shaka-project#1081)
feat: Move all third-party deps into git submodules (shaka-project#1083)
fix: Fix local files with UTF8 names (shaka-project#1246)
fix: Fix build on FreeBSD (shaka-project#1287)
fix: Fix clang build (shaka-project#1288)
fix: Fix various build issues on macOS
fix: Fix various build issues on Windows
END_COMMIT_OVERRIDE
@joeyparrish joeyparrish mentioned this pull request Nov 30, 2023
Merged
@shaka-bot shaka-bot mentioned this pull request Dec 1, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cosmin cosmin cosmin approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyparrish @cosmin