Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing DASH roles from ISO/IEC 23009-1 section 5.8.5.5 #1390

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented Apr 26, 2024

Per 5.8.5.5 of ISO-23009-1:2019 the values of role are

image

image

Fixes #1149

@cosmin cosmin requested a review from joeyparrish April 26, 2024 01:30
packager/app/packager_main.cc Outdated Show resolved Hide resolved
@cosmin cosmin merged commit fe885b3 into shaka-project:main Apr 30, 2024
35 checks passed
@cosmin cosmin deleted the add-missing-dash-roles branch April 30, 2024 21:10
cosmin pushed a commit that referenced this pull request May 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.1.0](v3.0.4...v3.1.0)
(2024-05-03)


### Features

* add missing DASH roles from ISO/IEC 23009-1 section 5.8.5.5
([#1390](#1390))
([fe885b3](fe885b3))
* get start number from muxer and specify initial sequence number
([#879](#879))
([bb104fe](bb104fe))
* teletext formatting
([#1384](#1384))
([4b5e80d](4b5e80d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing values for DASH role scheme
2 participants