fix: Add Missing Dash Roles to RoleFromString function (#1418) #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johmpa
changed the title
cosmin
approved these changes
Aug 14, 2024
cosmin
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [3.2.1](v3.2.0...v3.2.1) (2024-10-02) ### Bug Fixes * Add Missing Dash Roles to RoleFromString function ([#1418](#1418)) ([#1419](#1419)) ([9cb00e9](9cb00e9)) * Break header installation for the shared library ([#1407](#1407)) ([b5c2cb8](b5c2cb8)), closes [#1406](#1406) * Embed full python protobuf library ([#1438](#1438)) ([f07fd0d](f07fd0d)), closes [#1436](#1436) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #1418, several Dash roles are missing from the RoleFromString function, making them unusable in practice. This update should enable them for use.
BEGIN_COMMIT_OVERRIDE
fix: Add Missing Dash Roles to RoleFromString function (#1419)
Closes #1418
END_COMMIT_OVERRIDE