Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to ignore HTTP output failures #1449

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: Add option to ignore HTTP output failures #1449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packager/file/http_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ ABSL_FLAG(bool,
false,
"Disable peer verification. This is needed to talk to servers "
"without valid certificates.");
ABSL_FLAG(bool,
ignore_http_output_failures,
false,
"Ignore HTTP output failures. Can help recover from live stream "
"upload errors.");

ABSL_DECLARE_FLAG(uint64_t, io_cache_size);

Expand Down Expand Up @@ -257,7 +262,7 @@ Status HttpFile::CloseWithStatus() {
const Status result = status_;
LOG_IF(ERROR, !result.ok()) << "HttpFile request failed: " << result;
delete this;
return result;
return absl::GetFlag(FLAGS_ignore_http_output_failures) ? Status::OK : result;
}

bool HttpFile::Close() {
Expand Down
Loading