Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build TS caption metadata on-the-fly #1826

Closed
bkodirov opened this issue Feb 28, 2019 · 9 comments · Fixed by #6700
Closed

Build TS caption metadata on-the-fly #1826

bkodirov opened this issue Feb 28, 2019 · 9 comments · Fixed by #6700
Assignees
@avelad
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.9

Comments

@bkodirov
Copy link

Can Shaka player parse CEA 608 and provide a text track list?
We have an HLS stream which doesn't have closed CLOSED-CAPTIONS metadata in it. Meantime our TS files do have CEA 608 closed caption.
Currently, Exoplayer and AVPlayer are parsing TS and providing information about the CC. We can select that CC and player are rendering closed caption properly. Our chromecast app doesn't provide closed caption for the same stream. It is using
[ 4.815s] [cast.framework.common.libraryloader] library(//ajax.googleapis.com/ajax/libs/shaka-player/2.4.4/shaka-player.compiled.js) is loaded .
@bkodirov bkodirov added the type: question A question from the community label Feb 28, 2019
@joeyparrish
Copy link
Member

I believe we are driving the tracks API from the metadata in the HLS playlist. Can your playlist be fixed to signal the presence of the CC data?

@bkodirov
Copy link
Author

Unfortunately, our encoder doesn't provide CLOSED-CAPTION metadata in the Manifest.

@joeyparrish
Copy link
Member

Then I'll convert this into an "enhancement" issue to build CC metadata on-the-fly as captions are discovered in the content. Note that this would only work for TS content, and only with mux.js installed for transmuxing. In other cases, we would not have the opportunity to discover the captions. In MP4 content, we would not be parsing the content unless the metadata was there to signal the presence of embedded captions.

@joeyparrish joeyparrish added type: enhancement New feature or request and removed type: question A question from the community labels Feb 28, 2019
@joeyparrish joeyparrish changed the title Question: CEA 608 closed captions in TS Build TS caption metadata on-the-fly during transmuxing Feb 28, 2019
@bkodirov
Copy link
Author

Thank you. Since CAF(Chromecast) receiver uses shaka player, do you have any clue, whether it is gonna be available on the chromecast CAF?

@joeyparrish
Copy link
Member

The CAF team have their own release schedule, which I can't predict. But it would have to be in a Shaka Player release first, and this is not scheduled for a release yet.

@shaka-bot shaka-bot added this to the Backlog milestone Feb 28, 2019
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@michellezhuogg michellezhuogg mentioned this issue May 5, 2020
Closed
@joeyparrish
Copy link
Member

If anyone is interested in contributing a PR for this, please let us know! (Tagging @arturparkhisenko based on discussions in #2466.)

@joeyparrish joeyparrish added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label May 13, 2020
@theodab theodab added component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking labels Sep 30, 2021
@ashishTivo
Copy link

Hi, just checking if anyone working for detecting embedded closed captions if manifest doesnt have closed captions data?

@joeyparrish
Copy link
Member

I don't believe anyone is working on this at the moment. Would you like me to assign it to you?

@avelad avelad mentioned this issue Oct 25, 2023
Merged
avelad added a commit that referenced this issue Oct 26, 2023
@avelad
feat(HLS): Build closed captions metadata for media playlist on-the-f…
754bfac 
…ly. (#5811)

Related to #1826
@avelad avelad changed the title Build TS caption metadata on-the-fly during transmuxing Build TS caption metadata on-the-fly Nov 20, 2023
@avelad avelad mentioned this issue Nov 20, 2023
Closed
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
feat(HLS): Build closed captions metadata for media playlist on-the-f…
e18e3bf 
…ly. (shaka-project#5811)

Related to shaka-project#1826
@avelad
Copy link
Member

avelad commented Feb 1, 2024

We already support this functionality for when loading a media playlist.

@avelad avelad mentioned this issue May 29, 2024
Closed
@avelad avelad self-assigned this May 29, 2024
@avelad avelad removed the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label May 29, 2024
@avelad avelad modified the milestones: Backlog, v4.9 May 29, 2024
@avelad avelad mentioned this issue May 29, 2024
Merged
avelad added a commit that referenced this issue May 30, 2024
@avelad
feat(HLS): Build closed captions metadata on-the-fly (#6700)
082f897 
Closes #1826

Also fixes variable substitution when using `getMediaPlaylistBasicInfo_`
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 29, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@avelad avelad

Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.9
Development

Successfully merging a pull request may close this issue.

feat(HLS): Build closed captions metadata on-the-fly avelad/shaka-player
7 participants
@bkodirov @joeyparrish @avelad @shaka-bot @theodab @michellezhuogg @ashishTivo