Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect version number in player.js #30

Closed
allenevans opened this issue Mar 11, 2015 · 2 comments
Closed

Incorrect version number in player.js #30

allenevans opened this issue Mar 11, 2015 · 2 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@allenevans
Copy link

player.js still reports as v1.2.0

Line 118:
goog.define('GIT_VERSION', 'v1.2.0-debug');

This should be v1.2.1.
@joeyparrish
Copy link
Member

Whoops!

This bug affects both the v1.2.1 tag in github and the 1.2.1 release on npm.

Both show up as v1.2.0-debug in uncompiled mode. The npm release reports as v1.2.0-13-gfd26657, while the github release reports as v1.2.0-12-g77b7c7e.

@joeyparrish joeyparrish self-assigned this Mar 11, 2015
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Mar 11, 2015
joeyparrish added a commit that referenced this issue Mar 11, 2015
@joeyparrish
Fix version derivation from unannotated tags.
4fa805d 
Related to #30

Change-Id: I6f4175a6a2edeca9422cc4cf07a01356c305e9e1
joeyparrish added a commit that referenced this issue Mar 12, 2015
@joeyparrish
Add a script to check versions.
e2f31dd 
This script checks for versioning mistakes and will prevent npm
publication if any of the checks fail.

This also drops the check.sh script, which nobody was using.

Related to #30

Change-Id: Ic8e504515ac31beb7833207aa2ac463d40cfae88
joeyparrish added a commit that referenced this issue Mar 12, 2015
@joeyparrish
Fix version derivation from unannotated tags.
47459e8 
Related to #30

Change-Id: I6f4175a6a2edeca9422cc4cf07a01356c305e9e1
joeyparrish added a commit that referenced this issue Mar 12, 2015
@joeyparrish
Add a script to check versions.
0faef1e 
This script checks for versioning mistakes and will prevent npm
publication if any of the checks fail.

This also drops the check.sh script, which nobody was using.

Related to #30

Change-Id: Ic8e504515ac31beb7833207aa2ac463d40cfae88
joeyparrish added a commit that referenced this issue Mar 12, 2015
@joeyparrish
Bump version numbers to 1.2.2
877feaf 
Related to #30
@joeyparrish
Copy link
Member

  1. removed v1.2.1 from npm (since we can't change it)
  2. tightened up our release procedures and added some scripting to help us catch these problems before release
  3. published v1.2.2 on both github and npm with all of the version numbering fixed

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@allenevans @TheModMaker @joeyparrish @shaka-bot