Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMSC1 subtitles not working in a HLS stream #4350

Closed
duggaraju opened this issue Jul 14, 2022 · 2 comments · Fixed by #4942
Closed

IMSC1 subtitles not working in a HLS stream #4350

duggaraju opened this issue Jul 14, 2022 · 2 comments · Fixed by #4942
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@duggaraju
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?

What version of Shaka Player are you using?
4.1.1

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
both

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Windows 11, Microsoft edge/chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://aka.ms/LowLatencyDemo.m3u8

What configuration are you using? What is the output of player.getConfiguration()?

{
streaming: {
autoLowLatencyMode: true
}
}
setTextTracksVisible(true) or select it from the UI.

What did you do?

Just play the stream

What did you expect to happen?
the captions should be downloaded and visible.

What actually happened?

The fragments of the captions are not getting downloaded and not displayed.

@duggaraju duggaraju added the type: bug Something isn't working correctly label Jul 14, 2022
@github-actions github-actions bot added this to the v4.2 milestone Jul 14, 2022
@joeyparrish
Copy link
Member

The log is full of warnings like (text:8) cannot find segment lookupTime: 3664.425235271454 presentationTime: 3666.425235271454.

@joeyparrish joeyparrish added component: HLS The issue involves Apple's HLS manifest format component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 21, 2022
@avelad avelad modified the milestones: v4.2, v4.3 Aug 17, 2022
@ningl2
Copy link

ningl2 commented Oct 24, 2022

Is there an update on this issue. We have a test stream if needed. Thanks.

@avelad avelad modified the milestones: v4.3, v4.4 Nov 11, 2022
@avelad avelad self-assigned this Jan 30, 2023
joeyparrish pushed a commit that referenced this issue Jan 30, 2023
Fixes #4350

The current code initially parses the subtitle track as text/vtt
(mimetype) since it has no codec. Subsequently, the stpp.ttml.im1t codec
is assigned but the mimetype of text/vtt is not changed to
application/mp4. This PR changes this so that once the codec is
assigned, the mimetype is recalculated.
joeyparrish pushed a commit that referenced this issue Jan 30, 2023
Fixes #4350

The current code initially parses the subtitle track as text/vtt
(mimetype) since it has no codec. Subsequently, the stpp.ttml.im1t codec
is assigned but the mimetype of text/vtt is not changed to
application/mp4. This PR changes this so that once the codec is
assigned, the mimetype is recalculated.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants