Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Build closed captions metadata for media playlist on-the-fly. #5811

Merged
merged 3 commits into from
Oct 26, 2023
Merged

feat(HLS): Build closed captions metadata for media playlist on-the-fly. #5811

merged 3 commits into from
Oct 26, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 25, 2023

Related to #1826

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking labels Oct 25, 2023
@avelad avelad added this to the v4.6 milestone Oct 25, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 97.73%

theodab
theodab requested changes Oct 26, 2023
View reviewed changes
lib/media/segment_utils.js Show resolved Hide resolved
@avelad avelad requested a review from theodab October 26, 2023 06:19
theodab
theodab requested changes Oct 26, 2023
View reviewed changes
externs/shaka/manifest.js Outdated Show resolved Hide resolved
externs/shaka/manifest.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab October 26, 2023 06:41
@avelad avelad merged commit 754bfac into shaka-project:main Oct 26, 2023
16 checks passed
@avelad avelad deleted the media-playlist-detect-cc branch October 26, 2023 07:04
@shaka-bot shaka-bot mentioned this pull request Oct 26, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat(HLS): Build closed captions metadata for media playlist on-the-f…
e18e3bf 
…ly. (shaka-project#5811)

Related to shaka-project#1826
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 25, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab