Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OfflineVideoSource estimator argument should be nullable #72

Closed
joeyparrish opened this issue Apr 29, 2015 · 0 comments
Closed

OfflineVideoSource estimator argument should be nullable #72

joeyparrish opened this issue Apr 29, 2015 · 0 comments
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v1.3.1

Comments

@joeyparrish
Copy link
Member

DashVideoSource allows the estimator argument to be null. If one is not provided, DashVideoSource constructs a EWMABandwidthEstimator as a default to pass down to StreamVideoSource.

For consistency, let's do the same in OfflineVideoSource.
@joeyparrish joeyparrish added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors labels Apr 29, 2015
@joeyparrish joeyparrish added this to the v1.3.1 milestone Apr 29, 2015
natalieharris added a commit that referenced this issue May 22, 2015
@natalieharris @joeyparrish
Make OfflineVideoSource estimator arg nullable.
99397de 
Closes #72.

Change-Id: I73728c85ba8e8641a2a953c3ec11bcabc5ff6b2b
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v1.3.1
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @natalieharris @shaka-bot