CEA-608 Decoder #2731
Merged
CEA-608 Decoder #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed useless logs Added color support fixed up background attribute logic trim new lines on row ends and styling fix logic on clearing rollup captions when moving window hotfixes on decoder and tests fixed logic and added support for all charsets minor syntax fix renaming constants improve commenting, remove redundant comments move important hex into constants broke hex values in unit tests into constants comment fixing constant suffixes cleaned impl for streams/channel
clarification in comments
muhammadharis
force-pushed
the
mp4-cea-decoder
branch
from
b45fba7
to
1ebb6a9
Compare
made colors array more intuitive
muhammadharis
force-pushed
the
mp4-cea-decoder
branch
from
592a4b4
to
0a4ae52
Compare
…mp4-cea-decoder
This reverts commit d6786bf.
joeyparrish
requested changes
Aug 4, 2020
small unit test fix
muhammadharis
force-pushed
the
mp4-cea-decoder
branch
from
b5f7272
to
292c896
Compare
joeyparrish
requested changes
Aug 5, 2020
joeyparrish
requested changes
Aug 6, 2020
joeyparrish
reviewed
Aug 7, 2020
Comment on lines
+227
to
+228
| ccPacket.ccData1 &= 0x7f; | ||
| ccPacket.ccData2 &= 0x7f; |
There was a problem hiding this comment.
Are these packets completely discarded after decode() is complete? If so, this should be fine. But if they were ever re-processed, this would cause half your packets to fail the parity check on a second pass.
There was a problem hiding this comment.
Yes, once the decode is complete the packets are all cleared. There is no reprocessing of packets after.
joeyparrish
approved these changes
Aug 7, 2020
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pertains to #2648. A CEA-608 decoder that decodes CEA-608 (Line 21) data from User Data Registered by Rec. ITU-T T.35 SEI messages and returns them as cues in Shaka's internal cue format. This allows us to separately maintain our own decoder, and removes our dependency on the Mux.js caption decoder.
Format:
Cues are emitted in Shaka's internal format (lib/text/cue.js). This decoder makes use of nested cues. The top level cue is always a blank cue with no text, and each nested cue inside it contains text, as well as a specific style, or linebreak cues to facilitate line breaks. This also allows for inline style (color, italics, underline) changes.
Basic North American, Special North American, and Extended European Charsets supported.
Underlines, colors, and Italics supported, set as a property on each nested cue.
Text mode not emitted.
Positioning and alignment not supported.