Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed_#3571_seekRange().start is going back and forth while start-over #3664

Closed
wants to merge 1 commit into from

Conversation

pulkit-30
Copy link

@pulkit-30 pulkit-30 commented Sep 26, 2021

Fixes #3571

Description

Added a new get function getSeekRangeStartTime() in lib/media/presentation_timeline.js .
And changed the function to call getSeekRangeStartTime() instead of getSeekRangeStart() in lib/player.js.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

Please provide me appropriate feedback/review so that I can continue working on this.

@pulkit-30
Copy link
Author

@joeyparrish Please provide me with appropriate feedback/review so that I can continue working on this.

@joeyparrish
Copy link
Member

I'm not convinced this is correct for live streams. What content have you tested it on?

@pulkit-30
Copy link
Author

Thanks for your suggestion @joeyparrish. This didn't strike my mind previously. Perhaps my patch won't work with streams. Do you have any idea of how can I make it compatible with streams?

@joeyparrish
Copy link
Member

You'll need to test this with live streams. We have plenty in the demo app.

@avelad
Copy link
Member

avelad commented May 3, 2022

@pulkit-30 have you been able to test with live streams?

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 3, 2022
@avelad
Copy link
Member

avelad commented May 10, 2022

Closing due to inactivity.

@avelad avelad closed this May 10, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seekRange().start is going back and forth while start-over
3 participants