feat(HLS): Add HLS support for non-sequence mode #4623
Conversation
avelad
added
type: enhancement
avelad
force-pushed
the
hls-sequencemode
branch
from
8400e5c
to
888c9d7
Compare
avelad
force-pushed
the
hls-sequencemode
branch
from
888c9d7
to
5615689
Compare
|
Incremental code coverage: 61.59% |
avelad
force-pushed
the
hls-sequencemode
branch
2 times, most recently
from
8aa4cea
to
a0119c0
Compare
avelad
force-pushed
the
hls-sequencemode
branch
from
a0119c0
to
af638d1
Compare
# Conflicts: # lib/media/media_source_engine.js
avelad
force-pushed
the
hls-sequencemode
branch
from
b3b6359
to
0496915
Compare
# Conflicts: # lib/media/media_source_engine.js
# Conflicts: # lib/media/media_source_engine.js # lib/media/streaming_engine.js # test/media/streaming_engine_unit.js
# Conflicts: # lib/media/media_source_engine.js
|
@joeyparrish , do you think you'll have time this week to review it? |
|
Sorry, it turns out that I did not have time. I didn't even see this message until now. :-( The AV sync issues kept me very busy since the holidays, but now that I have close that issue and am preparing new releases, I should be able to catch up a bit on reviews next week. |
|
@joeyparrish friendly reminder! :) |
| reference.initSegmentReference && | ||
| reference.initSegmentReference.timescale) { | ||
| const timescale = reference.initSegmentReference.timescale; | ||
| if (!isNaN(timescale)) { |
There was a problem hiding this comment.
Would this be better as an assert? I don't know if the timescale being NaN is something that happens in realistic Mp4 content.
There was a problem hiding this comment.
This is realistic, because the timescale is obtained from the initialization segment, which is filled in elsewhere in the code.
|
Thanks @theodab ! |
github-actions
bot
added
the
status: archived
No description provided.