Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stop setting playbackRate to 0 to control buffering state #5696

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat: Stop setting playbackRate to 0 to control buffering state #5696

merged 1 commit into from
Oct 5, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 29, 2023

Closes #2093

@avelad avelad marked this pull request as draft September 29, 2023 11:00
@avelad avelad added type: enhancement New feature or request priority: P2 Smaller impact or easy workaround labels Sep 29, 2023
@avelad avelad added this to the v4.5 milestone Sep 29, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Sep 29, 2023 •
edited
Loading

Incremental code coverage: 90.00%

@avelad avelad marked this pull request as ready for review October 2, 2023 07:20
@avelad avelad merged commit 6156dce into shaka-project:main Oct 5, 2023
32 checks passed
@avelad avelad deleted the playback-rate-0 branch October 5, 2023 06:39
@shaka-bot shaka-bot mentioned this pull request Oct 5, 2023
Merged
@avelad avelad modified the milestones: v4.5, v4.6 Oct 5, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat: Stop setting playbackRate to 0 to control buffering state (shak…
30444b8 
…a-project#5696)

Closes shaka-project#2093
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 4, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Stop setting playbackRate to 0 to control buffering state
3 participants
@avelad @shaka-bot @theodab