Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Add custom mapping for bad codec declaration #5845

Closed
wants to merge 1 commit into from
Closed

fix(HLS): Add custom mapping for bad codec declaration #5845

wants to merge 1 commit into from

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 2, 2023

Related to #5797

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Nov 2, 2023
@avelad avelad added this to the v4.6 milestone Nov 2, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

littlespex
littlespex reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@littlespex littlespex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the player's responsibility? Shouldn't this be fixed in the packaging side??

@avelad
Copy link
Member Author

avelad commented Nov 2, 2023

Why is this the player's responsibility? Shouldn't this be fixed in the packaging side??

@littlespex I agree that it is a error of the packager, and that they should correct it, but it seemed like such a simple error to fix on our end... If you prefer, we discard this change, I would be fine too.

@littlespex
Copy link
Contributor

Personally I'd prefer a clear division of responsibilities by limiting hacks/workarounds to playback and platform related issues. Packaging and delivery issues should be handled external to the player. This is just my opinion, and I'm curious to hear what others think.

@alekzz
Copy link

alekzz commented Nov 2, 2023

I also think it's better to keep this logic out of the player. Maybe a workaround for the application can be to replace the codec in the manifest by registering the manifest response interceptor with NetworkingEngine#registerResponseFilter ?

@avelad avelad closed this Nov 2, 2023
@avelad avelad deleted the hls-bad-codecs branch November 2, 2023 17:24
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 1, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex left review comments

@theodab theodab Awaiting requested review from theodab

@alekzz alekzz Awaiting requested review from alekzz

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
4 participants
@avelad @shaka-bot @littlespex @alekzz