Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Add AES-256 and AES-256-CTR support #6002

Merged
merged 2 commits into from
Jan 9, 2024
Merged

feat(HLS): Add AES-256 and AES-256-CTR support #6002

merged 2 commits into from
Jan 9, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 7, 2023

Closes #6001

@avelad avelad marked this pull request as draft December 7, 2023 16:52
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Dec 7, 2023
@avelad avelad added this to the v5.0 milestone Dec 7, 2023
@avelad avelad force-pushed the aes-256-support branch 2 times, most recently from b386608 to b9c0ee9 Compare December 7, 2023 17:12
@avelad
Copy link
Member Author

avelad commented Dec 7, 2023

@theodab we have the same problem as #5834 :(

@avelad avelad marked this pull request as ready for review December 7, 2023 17:44
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 62.86%

@avelad avelad requested a review from theodab December 7, 2023 17:45
@theodab
Copy link
Contributor

theodab commented Jan 9, 2024

@theodab we have the same problem as #5834 :(

Could you add a check to this, like how we added a check in test/transmuxer/transmuxer_integration.js? If you can, I'd be okay with you adding a comment about this to #5834, since they seem to be similar issues.

@avelad avelad mentioned this pull request Jan 9, 2024
Closed
@avelad avelad merged commit c3380ce into shaka-project:main Jan 9, 2024
11 of 15 checks passed
@avelad avelad deleted the aes-256-support branch January 9, 2024 08:41
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

Add AES-256 and AES-256-CTR support
3 participants
@avelad @shaka-bot @theodab