fix(PS4): Fix serverCertificate defaulted to null #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to null (shaka-project#300) * Fix an issue on PS4 where serverCertificate is incorrectly defaulted to null * PR Comment
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
joeyparrish
approved these changes
May 31, 2024
joeyparrish
changed the title
|
Thank you for your contribution! |
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
For some reason on PS4, the check `val.buffer.constructor == ArrayBuffer` returns `false` when it should be `true` which causes the object cloning to return `null` instead of the array buffer. Modifying this to `val.buffer instanceof ArrayBuffer` now returns true which fixes the issue. This should work across devices. Original author: @nick-michael Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com>
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
For some reason on PS4, the check `val.buffer.constructor == ArrayBuffer` returns `false` when it should be `true` which causes the object cloning to return `null` instead of the array buffer. Modifying this to `val.buffer instanceof ArrayBuffer` now returns true which fixes the issue. This should work across devices. Original author: @nick-michael Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com>
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
For some reason on PS4, the check `val.buffer.constructor == ArrayBuffer` returns `false` when it should be `true` which causes the object cloning to return `null` instead of the array buffer. Modifying this to `val.buffer instanceof ArrayBuffer` now returns true which fixes the issue. This should work across devices. Original author: @nick-michael Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com>
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
For some reason on PS4, the check `val.buffer.constructor == ArrayBuffer` returns `false` when it should be `true` which causes the object cloning to return `null` instead of the array buffer. Modifying this to `val.buffer instanceof ArrayBuffer` now returns true which fixes the issue. This should work across devices. Original author: @nick-michael Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com>
tykus160
added a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
Jun 3, 2024
For some reason on PS4, the check `val.buffer.constructor == ArrayBuffer` returns `false` when it should be `true` which causes the object cloning to return `null` instead of the array buffer. Modifying this to `val.buffer instanceof ArrayBuffer` now returns true which fixes the issue. This should work across devices. Original author: @nick-michael Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason on PS4, the check
val.buffer.constructor == ArrayBufferreturnsfalsewhen it should betruewhich causes the object cloning to returnnullinstead of the array buffer.Modifying this to
val.buffer instanceof ArrayBuffernow returns true which fixes the issue. This should work across devices.Original author: @nick-michael