Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Add support for EXT-X-DATERANGE #6718

Merged
merged 7 commits into from
Jun 3, 2024
Merged

feat(HLS): Add support for EXT-X-DATERANGE #6718

merged 7 commits into from
Jun 3, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 31, 2024

Closes #3523

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels May 31, 2024
@avelad avelad added this to the v4.10 milestone May 31, 2024
@avelad avelad marked this pull request as draft May 31, 2024 09:12
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 31, 2024 •
edited
Loading

Incremental code coverage: 90.54%

@avelad avelad force-pushed the ext-x-daterange branch from c7ef669 to 4618d54 Compare May 31, 2024 09:49
@avelad avelad marked this pull request as ready for review May 31, 2024 10:25
@avelad avelad requested review from joeyparrish and theodab May 31, 2024 10:25
theRealRobG
theRealRobG reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@theRealRobG theRealRobG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind me dropping in on this, but we've recently had a lot of conversation around date ranges and program date times, so I thought I might be able to add something here. As such I left some comments.

lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
theodab
theodab requested changes Jun 3, 2024
View reviewed changes
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/player.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab June 3, 2024 06:47
@avelad avelad merged commit 2ec6444 into shaka-project:main Jun 3, 2024
15 of 16 checks passed
@avelad avelad deleted the ext-x-daterange branch June 3, 2024 08:10
@shaka-bot shaka-bot mentioned this pull request Jun 3, 2024
Merged
tykus160 pushed a commit to sky-hugolima/shaka-player-contrib that referenced this pull request Jun 3, 2024
@avelad @tykus160
feat(HLS): Add support for EXT-X-DATERANGE (shaka-project#6718)
e6eb7e1 
Closes shaka-project#3523
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 2, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theRealRobG theRealRobG theRealRobG left review comments

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.

Hook / Plugin Access HLS Playlist Custom Tags
4 participants
@avelad @shaka-bot @theRealRobG @theodab