Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectAudioLanguage() should ignore unplayable variants #6805

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

tykus160
Copy link
Member

When restrictions are set, selectAudioLanguage() ignores them and may suggest variant that is marked as unplayable.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jun 12, 2024
@avelad avelad added this to the v4.10 milestone Jun 12, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 95590ad into shaka-project:main Jun 12, 2024
16 of 17 checks passed
@tykus160 tykus160 deleted the wt-play-playable branch June 13, 2024 10:30
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants