Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix skip functionality in MediaTailor #6910

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 25, 2024

Fixes #6909

@avelad avelad force-pushed the skip-mediatailor branch from aa76823 to ae14da5 Compare June 25, 2024 13:04
@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jun 25, 2024
@avelad avelad added this to the v4.10 milestone Jun 25, 2024
@avelad avelad requested a review from theodab June 25, 2024 13:04
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 35.48%

lib/ads/media_tailor_ad.js Show resolved Hide resolved
@avelad avelad requested a review from theodab June 26, 2024 08:25
@avelad avelad merged commit 339bab4 into shaka-project:main Jun 26, 2024
15 of 16 checks passed
@avelad avelad deleted the skip-mediatailor branch June 26, 2024 08:50
avelad added a commit that referenced this pull request Jun 27, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 25, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip button with Media Tailor remains disabled
3 participants