Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't clear the buffer when disable a stream #6931

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 27, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Jun 27, 2024
@avelad avelad added this to the v4.10 milestone Jun 27, 2024
@avelad avelad requested a review from theodab June 27, 2024 13:07
@avelad avelad force-pushed the clear-buffer-disable-stream branch from 639424f to 53ad5a8 Compare June 27, 2024 13:17
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 5dac2c0 into shaka-project:main Jun 28, 2024
27 of 30 checks passed
@avelad avelad deleted the clear-buffer-disable-stream branch June 28, 2024 08:47
@cristian-atehortua
Copy link
Contributor

Can this be cherry-picked to v4.8.x and v4.9.x?

@avelad
Copy link
Member Author

avelad commented Jun 29, 2024

Can this be cherry-picked to v4.8.x and v4.9.x?

Yes!

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants