Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update usage of minBufferTime according to the DASH spec #7616

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 18, 2024

Related to #7602 (comment)

From 23009-1:

The value of the minimum buffer time does not provide any instructions to the client on how long
to buffer the media. The value however describes how much buffer a client should have under
ideal network conditions. As such, MBT is not describing the burstiness or jitter in the network,
it is describing the burstiness or jitter in the content encoding. Together with the BW value, it is
a property of the content. Using the "leaky bucket" model, it is the size of the bucket that makes
BW true, given the way the content is encoded

@avelad avelad added type: enhancement New feature or request priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Nov 18, 2024
@avelad avelad added this to the v4.13 milestone Nov 18, 2024
@avelad avelad requested a review from tykus160 November 18, 2024 10:09
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me, but let's wait for other opinions.

lib/dash/dash_parser.js Show resolved Hide resolved
@avelad avelad requested a review from theodab November 18, 2024 13:59
@avelad avelad merged commit 2260aa9 into shaka-project:main Nov 19, 2024
18 checks passed
@avelad avelad deleted the min-buffer-time branch November 19, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants