Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stop setting playbackRate to 0 to control buffering state when streaming.rebufferingGoal = 0 #7617

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 18, 2024

Close #7602

@avelad avelad added type: enhancement New feature or request priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 18, 2024
@avelad avelad added this to the v4.13 milestone Nov 18, 2024
lib/player.js Outdated Show resolved Hide resolved
lib/media/buffering_observer.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab November 18, 2024 13:43
@avelad
Copy link
Member Author

avelad commented Nov 19, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7617

@avelad avelad merged commit 84b64af into shaka-project:main Nov 20, 2024
31 of 32 checks passed
@avelad avelad deleted the rebufferingGoal branch November 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using playback rate manipulation for buffer management
4 participants