Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ads): Add support for images and iframes in interstitials #7712

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat(Ads): Add support for images and iframes in interstitials #7712

merged 1 commit into from
Dec 4, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 4, 2024

No description provided.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Dec 4, 2024
@avelad avelad added this to the v4.13 milestone Dec 4, 2024
@avelad avelad requested a review from theodab December 4, 2024 10:34
theodab
theodab approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the diff that git provided for this one was unusually misleading. It made this change look a lot more complicated than it actually is.

@avelad avelad merged commit 8db876f into shaka-project:main Dec 4, 2024
20 of 21 checks passed
@avelad avelad deleted the image-iframe-ads branch December 4, 2024 15:11
@shaka-bot shaka-bot mentioned this pull request Dec 4, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 2, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @theodab @shaka-bot