fix: Avoid stack overflow when stringifying objects #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add special case for arrays, for compatibility with frameworks or polyfills that add properties to Array or Array instances. Add special case for functions, which always contain circular references and are unexpected in this context. These seem to appear because of the frameworks/polyfills mentioned above.
|
Incremental code coverage: 98.63% |
joeyparrish
changed the title
joeyparrish
requested review from
avelad,
JulianDomingo,
tykus160,
littlespex and
theodab
|
Reporter on video-dev Slack confirms that this fixes the issue for him! |
|
I just made those edits in the GitHub web UI, so I'll be cautious and let the lint & test runs complete before merging. |
joeyparrish
added a commit
that referenced
this pull request
Dec 11, 2024
Add special case for arrays, for compatibility with frameworks or polyfills that add properties to Array or Array instances. Add special case for functions, which always contain circular references and are unexpected in this context. These seem to appear because of the frameworks/polyfills mentioned above. Move everything to ObjectUtils, since this is extremely generic. Closes #7435
joeyparrish
added a commit
that referenced
this pull request
Dec 12, 2024
Add special case for arrays, for compatibility with frameworks or polyfills that add properties to Array or Array instances. Add special case for functions, which always contain circular references and are unexpected in this context. These seem to appear because of the frameworks/polyfills mentioned above. Move everything to ObjectUtils, since this is extremely generic. Closes #7435
joeyparrish
added a commit
that referenced
this pull request
Dec 12, 2024
Add special case for arrays, for compatibility with frameworks or polyfills that add properties to Array or Array instances. Add special case for functions, which always contain circular references and are unexpected in this context. These seem to appear because of the frameworks/polyfills mentioned above. Move everything to ObjectUtils, since this is extremely generic. Closes #7435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add special case for arrays, for compatibility with frameworks or polyfills that add properties to Array or Array instances.
Add special case for functions, which always contain circular references and are unexpected in this context. These seem to appear because of the frameworks/polyfills mentioned above.
Move everything to ObjectUtils, since this is extremely generic.
Closes #7435