fix: re-open the MediaSource if readyState is not open when the init() method is called.
#7783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianDomingo
added
type: bug
joeyparrish
approved these changes
Dec 19, 2024
lib/media/media_source_engine.js
Outdated
| @@ -551,6 +551,13 @@ shaka.media.MediaSourceEngine = class { | |||
| const ContentType = shaka.util.ManifestParserUtils.ContentType; | |||
|
|
|||
| await this.mediaSourceOpen_; | |||
| if (this.ended() || this.closed()) { | |||
| shaka.log.debug('Expected MediaSource to be open during init(); ' + | |||
There was a problem hiding this comment.
This only occurs if one of these is true:
- Shaka has a serious bug
- Someone takes the video element out from under Shaka (misusing Shaka)
We should upgrade this to an error and show it in production, too. Please use shaka.log.alwaysError().
There was a problem hiding this comment.
Also please fix the linter errors (all line length errors)
…debug => alwaysError.
|
Incremental code coverage: 94.12% |
joeyparrish
pushed a commit
that referenced
this pull request
Jan 6, 2025
…init()` method is called. (#7783) Builds on top of @tykus160's observation in #4903 where `MediaSource.readyState` was either in a `closed` or `ended` state when the `MediaSourceEngine.init()` logic is executed. This fix will simply re-open the `MediaSource` if non-open, resulting in fewer scenarios where the `MEDIA_SOURCE_OPERATION_THREW` error: https://github.com/shaka-project/shaka-player/blob/de0f33c2623b057e80b7cafd53e19fac2f984961/lib/media/media_source_engine.js#L648-L651 is thrown because of an [`InvalidStateError`](https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/addSourceBuffer#exceptions).
joeyparrish
pushed a commit
that referenced
this pull request
Jan 6, 2025
…init()` method is called. (#7783) Builds on top of @tykus160's observation in #4903 where `MediaSource.readyState` was either in a `closed` or `ended` state when the `MediaSourceEngine.init()` logic is executed. This fix will simply re-open the `MediaSource` if non-open, resulting in fewer scenarios where the `MEDIA_SOURCE_OPERATION_THREW` error: https://github.com/shaka-project/shaka-player/blob/de0f33c2623b057e80b7cafd53e19fac2f984961/lib/media/media_source_engine.js#L648-L651 is thrown because of an [`InvalidStateError`](https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/addSourceBuffer#exceptions).
joeyparrish
pushed a commit
that referenced
this pull request
Jan 6, 2025
…init()` method is called. (#7783) Builds on top of @tykus160's observation in #4903 where `MediaSource.readyState` was either in a `closed` or `ended` state when the `MediaSourceEngine.init()` logic is executed. This fix will simply re-open the `MediaSource` if non-open, resulting in fewer scenarios where the `MEDIA_SOURCE_OPERATION_THREW` error: https://github.com/shaka-project/shaka-player/blob/de0f33c2623b057e80b7cafd53e19fac2f984961/lib/media/media_source_engine.js#L648-L651 is thrown because of an [`InvalidStateError`](https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/addSourceBuffer#exceptions).
joeyparrish
pushed a commit
that referenced
this pull request
Jan 6, 2025
…init()` method is called. (#7783) Builds on top of @tykus160's observation in #4903 where `MediaSource.readyState` was either in a `closed` or `ended` state when the `MediaSourceEngine.init()` logic is executed. This fix will simply re-open the `MediaSource` if non-open, resulting in fewer scenarios where the `MEDIA_SOURCE_OPERATION_THREW` error: https://github.com/shaka-project/shaka-player/blob/de0f33c2623b057e80b7cafd53e19fac2f984961/lib/media/media_source_engine.js#L648-L651 is thrown because of an [`InvalidStateError`](https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/addSourceBuffer#exceptions). Release-As: 4.9.2-caf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of @tykus160's observation in #4903 where
MediaSource.readyStatewas either in aclosedorendedstate when theMediaSourceEngine.init()logic is executed.This fix will simply re-open the
MediaSourceif non-open, resulting in fewer scenarios where theMEDIA_SOURCE_OPERATION_THREWerror:shaka-player/lib/media/media_source_engine.js
Lines 648 to 651 in de0f33c
is thrown because of an
InvalidStateError.