Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve times of probeSupport #7889

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 15, 2025

Fixes to #7449

@avelad
Copy link
Member Author

avelad commented Jan 15, 2025

@shaka-bot test

@avelad avelad changed the title chore: Improve times of probeSupport perf: Improve times of probeSupport Jan 15, 2025
@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7889

@avelad avelad added type: performance A performance issue priority: P2 Smaller impact or easy workaround labels Jan 15, 2025
@avelad avelad added this to the v4.13 milestone Jan 15, 2025
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jan 15, 2025

Incremental code coverage: 91.11%

Comment on lines +2075 to +2076
// FairPlay is a proprietary DRM from Apple and will never work on
// Windows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never say never 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want a better phrase, I'm willing to change it!

@avelad avelad merged commit c4931c1 into shaka-project:main Jan 15, 2025
20 checks passed
@avelad avelad deleted the probe-support branch January 15, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: performance A performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants