Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging support #12

Open
joeyparrish opened this issue Aug 30, 2019 · 0 comments
Open

Add logging support #12

joeyparrish opened this issue Aug 30, 2019 · 0 comments
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone
Backlog

Comments

@joeyparrish
Copy link
Member

Currently, all of the output from ffmpeg and packager goes to the terminal. It would be nice if this output could be optionally ignored, logged (separately for each process), or shown. When the output of ffmpeg is not being shown, it would be nice to have some status from Shaka Streamer so that the user could see roughly what is happening, but in an easy-to-read format.
@joeyparrish joeyparrish added the type: enhancement New feature or request label Aug 30, 2019
@joeyparrish joeyparrish added this to the v1.0 milestone Aug 30, 2019
shaka-bot pushed a commit that referenced this issue Oct 7, 2019
@joeyparrish
Allow control over output and environment for nodes
f8c4bb8 
Each node that creates a subprocess now has control over the output
handles and environment variables for the subprocess.  This will
enable environment-based logging (as ffmpeg uses) or logging based on
a file handle.

This is a step toward logging support.

Issue #12

Change-Id: I717d411e4b708eeaf05af03e1a16602336c2d065
shaka-bot pushed a commit that referenced this issue Oct 7, 2019
@joeyparrish
Add a setting for debug logging
67ac9e4 
This is very primitive logging, with no control over output filenames,
paths, or log rotation.  As such, it is only meant for debugging.

To enable, set debug_logs: true in the pipeline config.

Issue #12

Change-Id: I16696b5cea54579b921ff8186c944e8e5a5939fc
@joeyparrish joeyparrish modified the milestones: v1.0, Backlog Oct 10, 2019
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@joeyparrish