-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud): Upload through HTTP proxy node #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to play with this locally for a bit. I might be able to make some concrete suggestions or contribute to your branch.
My Google's docs say:
|
I'm going to revive this and push changes into your branch so you are properly credited for the PR. Changes I'm planning for this PR:
I'll follow up later with new changes to:
|
I've started by rolling up your original commits, rebasing them, and force-pushing. |
- Add convenience script for linting and testing - Revert -c for compatibility - Remove -H (use case unclear) - Do not treat proxy node as special - Simplify interface to proxy node - Simplify proxy node internals to use Python libraries for GCS and S3 - Disable multiperiod with cloud upload (for now) - Revert changes to multiperiod node
@mariocynicys, still a WIP since I haven't finished the S3 upload yet, but it's working well enough for GCS that I'm going to deploy it to my lab to revive our live stream. Without this, my live stream was running into errors where gsutil would leave files behind in /tmp and fill up the disk. Please take a look and give me your thoughts. |
Okay, S3 is working now, too. |
This is working in our lab deployment now! |
@joeyparrish now that 1.0.0 is out we started using it and discovered that HTTP was removed
This was actually how we were using the streamer, as we use storage that is neither S3 or GCS. If you're doing that, the only option was HTTP. If there was some kind of storage adapter that would be nice and we'd write our own adapter, however in the absence of that HTTP was our only option. Any possibility to get it added back? |
Yes, definitely. What are your requirements? Do you need specific headers or auth tokens, or just for Packager to write output directly to an HTTP(S) URL? |
@jspizziri, I filed #210 to discuss your requirements for HTTP upload. Please let us know what you need! |
Changes:
Closes #47