feat: Use by default VP9 with mp4 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
force-pushed
the
vp-mp4-default
branch
from
5dce50e
to
1662847
Compare
avelad
force-pushed
the
vp-mp4-default
branch
from
1662847
to
1b4cc64
Compare
Comment on lines
-868
to
-872
| if (manifestUrl == hlsManifestUrl) { | ||
| expect(codecList).not.toContain(jasmine.stringMatching('vp09.*')); | ||
| } else if (manifestUrl == dashManifestUrl) { | ||
| expect(codecList).toContain(jasmine.stringMatching('vp09.*')); | ||
| } |
There was a problem hiding this comment.
why are we removing this test?
There was a problem hiding this comment.
because it is no longer necessary since we now always use mp4
joeyparrish
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VP9 in MP4 has been supported in Chrome since Chrome 60 (https://chromestatus.com/feature/5762080762232832), which was released in June 2017, so it's been over 7 years!