Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka Packager Raw Key support #63

Merged
merged 4 commits into from
Nov 12, 2020

Conversation

cstranex
Copy link
Contributor

See #21 - Adds support for using raw key encryption.

Retains backwards compatibility with the existing Widevine encryption by adding an encryption_mode directive to the encryption configuration.

Also adds drm_label and skip_encryption to inputs.

@google-cla
Copy link

google-cla bot commented Oct 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cstranex
Copy link
Contributor Author

@googlebot I signed it!

@cstranex
Copy link
Contributor Author

@joeyparrish would you mind reviewing when you have a chance? 😄

@cstranex
Copy link
Contributor Author

ping

@cstranex
Copy link
Contributor Author

cstranex commented Nov 9, 2020

@joeyparrish would you mind reviewing?

@joeyparrish
Copy link
Member

I'm sorry for the delay. We have too few people on too many projects at the moment. I'm looking at it now.

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really well done. Thank you so much for your contribution!


label = configuration.Field(str).cast()
"""An arbitary string or a predefined DRM label like AUDIO, SD, HD, etc.
If not specified, indicates the default key and key_id."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this part. What do you mean by default key and key id? Are you saying the associated key and key id from this raw key entry is a default applied to all tracks without their own label? (AUDIO, SD, HD, etc?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct, similar wording to the shaka-packager documentation but I omitted the last sentence which maybe clarifies it better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now I think I understand. How about we review docs at some point on our side for clarity, but I don't put you through any more trouble on this PR. This seems fine for now.

Thank you again for your contribution!

@cstranex
Copy link
Contributor Author

This is really well done. Thank you so much for your contribution!

Always a pleasure :)

@joeyparrish joeyparrish merged commit ddfd796 into shaka-project:master Nov 12, 2020
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants