-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaka Packager Raw Key support #63
Shaka Packager Raw Key support #63
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@joeyparrish would you mind reviewing when you have a chance? 😄 |
ping |
@joeyparrish would you mind reviewing? |
I'm sorry for the delay. We have too few people on too many projects at the moment. I'm looking at it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really well done. Thank you so much for your contribution!
|
||
label = configuration.Field(str).cast() | ||
"""An arbitary string or a predefined DRM label like AUDIO, SD, HD, etc. | ||
If not specified, indicates the default key and key_id.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this part. What do you mean by default key and key id? Are you saying the associated key and key id from this raw key entry is a default applied to all tracks without their own label? (AUDIO, SD, HD, etc?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's correct, similar wording to the shaka-packager documentation but I omitted the last sentence which maybe clarifies it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now I think I understand. How about we review docs at some point on our side for clarity, but I don't put you through any more trouble on this PR. This seems fine for now.
Thank you again for your contribution!
Always a pleasure :) |
See #21 - Adds support for using raw key encryption.
Retains backwards compatibility with the existing Widevine encryption by adding an
encryption_mode
directive to the encryption configuration.Also adds drm_label and skip_encryption to inputs.