fix(HLS concatenation): Use posixpath for any path joining written in self.content
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding period concatenation for dash, no tests are done yet.
Before the `Channel count as an input feature` PR or rather `Channel layout as an input feature` shall i say, we had this problem where we are not guaranteed that a lower channel count exists for every input. For example, an input(period) might have six channel and no two channel, while another input might have two channels AND six channels, though in this configuration we have 2 & 6 channels but we can't generate 2 playlists (2 & 6), what we can do instead in this case is to generate two playlists, one has (2 and 6 channels) and one having (6 and 6 channels), And we have to mark both playlists with `CHANNELS="6"` because both of them has a maximum of 6 channel count across all periods, and also since the audio playlist is a media playlist, so no way for shaka player to know the bitrate for each playlists, so shaka player will just look at these playlists as identical. With the new change, we are guaranteed to have the lower channel for some input if a higher one exist (e.g if an input has 6 channels so it must have 2 also). This way we can set the `CHANNELS="val"` attribute appropriately and we guarantee that we will generate a playlist for each unique channel layout we have in the inputs.
Use `posixpath` module instead of `os.path` when updating the media files paths, `os.path` will resolve to `ntpath` on Windows, which uses a backslash for path joining instead of a forward slash.
mariocynicys
changed the title
posixpath for any path joining written in self.content
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
BaseURLtag that we insert under"urn:mpeg:dash:schema:mpd:2011". It would work fine either way(with or without the namespace) since we register this namespace we insert as the default namespace a couple of line later. But this change was to fix a potential error that could occur if we stop registeringdefault_dash_namespace(=="urn:mpeg:dash:schema:mpd:2011") to be the default one.posixpathmodule for joining the paths to the media segments. Since we write these paths in media playlist files at the end, they should all be using a forward slash as a separator, which is not the case for windows usingos.path. This wasn't breaking in Shaka Player for some reason, but i reckon it might break in other HLS players.