fix(external command): Create the new shell process in a new group #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching a process as a shell, what happens is that
Popen
creates a shell then the shell forks itself and callsexev
system call to run the program we intended to run in the shell.We have access to the shell it self from
self._process
which we actually don't need. We need the pid ofexternal-command
instead.This PR launches the spawned shell in a new group so that we can just kill the group all together when
stop
is called.fixes #46