Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom boostraprc location #114

Merged
merged 4 commits into from
Aug 1, 2016
Merged

Custom boostraprc location #114

merged 4 commits into from
Aug 1, 2016

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jul 31, 2016 •
edited
Loading

Option to run multiple variations of the .bootstraprc file against the same project. This fork lets developers pass in the location of their .bootstraprc file and cleans up some of the inter-dependencies between bootstrap.loader.js and bootstrap.config.js around creation of the config object.

Addresses #75.

This change is Reviewable

Andrew Ralston and others added 2 commits July 29, 2016 09:16
make the .bootstraprc location customizable
179d492
@justin808
Additions to pherris code for a custom bootstraprc
6ecbcce 
* Fixes handling of default configuration when there's neither a custom
  bootstraprc location nor a user supplied .bootstraprc.
* More logging
* Configured the css modules example to use either a fixed file or a
  specified location.
* Made the shorter script names be the ones that use file location as
  that is better for testing the examples, as changes to the
  .bootstraprc file get overwritten.
@justin808
Copy link
Member Author

justin808 commented Jul 31, 2016 •
edited
Loading

@pherris @vpanjganj Please make comments in reviewable. I'd like to get this one closed up ASAP. Please test the scripts per my suggestions in the CONTRIBUTING.md file.

@justin808 justin808 mentioned this pull request Jul 31, 2016
Closed
@justin808
Copy link
Member Author

I've published 1.1.0-beta.1. I'm awaiting review comments and somebody to verify that the new build works.

This was referenced Jul 31, 2016
Closed
Merged
Closed
Merged
Closed
@alex35mil
Copy link
Member

:lgtm: One comment.

I'll try beta on fng and, if it works w/o issues, let's merge.

Reviewed 6 of 13 files at r1, 13 of 13 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

examples/basic/package.json, line 57 [r3] (raw file):

    "babel-preset-es2015": "^6.1.18",
    "body-parser": "^1.14.1",
    "bootstrap-loader": "file:///Users/justin/shakacode/webpack/bootstrap-loader",

⚠️ Local path.

Comments from Reviewable

@justin808
Copy link
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.

examples/basic/package.json, line 57 [r3] (raw file):

Previously, alexfedoseev (Alex Fedoseev) wrote…

⚠️ Local path.

Arghhh...

Comments from Reviewable

@justin808
Copy link
Member Author

Review status: 18 of 20 files reviewed at latest revision, 1 unresolved discussion.

examples/basic/package.json, line 57 [r3] (raw file):

Previously, justin808 (Justin Gordon) wrote…

Arghhh...

FIXED

Comments from Reviewable

@justin808
Copy link
Member Author

OK!

Review status: 18 of 20 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@alex35mil
Copy link
Member

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@justin808 justin808 merged commit da8d7ab into master Aug 1, 2016
@justin808 justin808 deleted the custom-boostraprc-location branch August 1, 2016 08:04
justin808 added a commit that referenced this pull request Aug 1, 2016
@justin808
Custom boostraprc location (#114)
f077a53 
* make the .bootstraprc location customizable
* Fixes handling of default configuration when there's neither a custom
  bootstraprc location nor a user supplied .bootstraprc.
* More logging
* Configured the css modules example to use either a fixed file or a
  specified location.
* Made the shorter script names be the ones that use file location as
  that is better for testing the examples, as changes to the
  .bootstraprc file get overwritten.
justin808 added a commit that referenced this pull request Aug 4, 2016
@justin808
Custom boostraprc location (#114)
a1a9935 
* make the .bootstraprc location customizable
* Fixes handling of default configuration when there's neither a custom
  bootstraprc location nor a user supplied .bootstraprc.
* More logging
* Configured the css modules example to use either a fixed file or a
  specified location.
* Made the shorter script names be the ones that use file location as
  that is better for testing the examples, as changes to the
  .bootstraprc file get overwritten.
justin808 added a commit that referenced this pull request Aug 31, 2016
@justin808
Custom boostraprc location (#114)
d99a743 
* make the .bootstraprc location customizable
* Fixes handling of default configuration when there's neither a custom
  bootstraprc location nor a user supplied .bootstraprc.
* More logging
* Configured the css modules example to use either a fixed file or a
  specified location.
* Made the shorter script names be the ones that use file location as
  that is better for testing the examples, as changes to the
  .bootstraprc file get overwritten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin808 @alex35mil