-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow webpack-cli
6.x (non-breaking)
#533
Conversation
WalkthroughThe pull request introduces updates to the Shakapacker library, focusing on expanding compatibility with newer versions of webpack-related tools. The changes primarily involve updating the Changes
Assessment against linked issues
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
69122a9
to
6a99b73
Compare
webpack-cli
6.x (non-breaking)webpack-cli
6.x (non-breaking, requires #536)
6a99b73
to
8492893
Compare
webpack-cli
6.x (non-breaking, requires #536)webpack-cli
6.x (non-breaking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
15-15
: Fix markdown list style inconsistency.The unordered list uses a dash (-) while the markdownlint tool expects an asterisk (*) to maintain consistent list marker style throughout the document.
-- Allow `webpack-cli` v6. [PR 533](https://github.com/shakacode/shakapacker/pull/533) by [tagliala](https://github.com/tagliala). +* Allow `webpack-cli` v6. [PR 533](https://github.com/shakacode/shakapacker/pull/533) by [tagliala](https://github.com/tagliala).🧰 Tools
🪛 Markdownlint (0.37.0)
15-15: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)package.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🧰 Additional context used
🪛 Markdownlint (0.37.0)
CHANGELOG.md
15-15: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
🔇 Additional comments (1)
CHANGELOG.md (1)
13-16
: LGTM! Clear documentation of the new feature.The changelog entry properly documents the addition of webpack-cli v6 support with a link to the PR and attribution to the contributor.
🧰 Tools
🪛 Markdownlint (0.37.0)
15-15: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Blocked by:
Close #532
Summary
Pull Request checklist
Other Information
Please test
Summary by CodeRabbit
Summary by CodeRabbit
New Features
webpack-cli
v6.ensure_consistent_versioning
.Breaking Changes
verify_file_existence
,yarn_install
, andcheck_yarn
.Bug Fixes
Documentation